Add a reauthenticate method to expose refresh token use#167
Open
tqc wants to merge 1 commit intofullstackreact:masterfrom
Open
Add a reauthenticate method to expose refresh token use#167tqc wants to merge 1 commit intofullstackreact:masterfrom
tqc wants to merge 1 commit intofullstackreact:masterfrom
Conversation
|
@tqc, what about |
Contributor
Author
|
@monolithed An expiry time isn’t needed - if the token you have doesn’t work, try getting a new one. You could check the expiry beforehand if you really wanted to, but it wouldn’t be particularly reliable anyway - there are plenty of other reasons for a token to expire. |
|
Something like this would be really helpful for me, since I'm having a hard time getting makeRequest to work, but JS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update improves the handling of refresh tokens when using a javascript api rather than the native makeRequest. Somewhat related to #82.
JS code can call reauthenticate to get a new token when a request fails due to an expired token.
I also added saving of the new token after a refresh - previously the new token would be in memory for subsequent makeRequest calls, but the next app startup would return the expired token.
iOS only for now - the android implementation is fairly straightforward, but isn't included as I'm not set up to test that at the moment.